Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical alignment in format expression #5043

Merged
Merged
Show file tree
Hide file tree
Changes from 48 commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
ac7cec8
add support for `top` alingment
stanislawpuda-tomtom Oct 7, 2024
c0b7b95
add support for "center" alignment
stanislawpuda-tomtom Oct 7, 2024
4b7e0ae
add comments
stanislawpuda-tomtom Oct 7, 2024
395a9db
render tests
zbigniewmatysek-tomtom Oct 15, 2024
9eecb22
handle vertical text
zbigniewmatysek-tomtom Oct 15, 2024
51ad9c2
cleanout
zbigniewmatysek-tomtom Oct 15, 2024
d1dd1ce
update top alignment
zbigniewmatysek-tomtom Oct 16, 2024
e4d36cd
cleanout
zbigniewmatysek-tomtom Oct 16, 2024
f381f8c
refactor shaping
zbigniewmatysek-tomtom Oct 18, 2024
04a46c4
Fix vertical alignment
zbigniewmatysek-tomtom Oct 21, 2024
f177852
fix bbox size
zbigniewmatysek-tomtom Oct 21, 2024
2f3cc78
adjust line spacing
zbigniewmatysek-tomtom Oct 22, 2024
e8f916d
vertical placement
zbigniewmatysek-tomtom Oct 22, 2024
7b174cf
cleanout
zbigniewmatysek-tomtom Oct 23, 2024
33f7d6f
handle text offset
zbigniewmatysek-tomtom Oct 23, 2024
70c4b94
minor fix
zbigniewmatysek-tomtom Oct 23, 2024
3fa48a9
const glyph height
zbigniewmatysek-tomtom Oct 29, 2024
a471167
align when no big image
stanislawpuda-tomtom Nov 3, 2024
dd30b1f
use section.scale when multiplying on image
stanislawpuda-tomtom Nov 4, 2024
e01a437
fix big image case
stanislawpuda-tomtom Nov 5, 2024
f14bd5d
fix vertical
stanislawpuda-tomtom Nov 5, 2024
5b04aed
simplify imageOffset calculation
stanislawpuda-tomtom Nov 8, 2024
5462948
code simplification
stanislawpuda-tomtom Nov 8, 2024
966c17d
improve readability
stanislawpuda-tomtom Nov 11, 2024
4863b92
cleaning - removing dead code
stanislawpuda-tomtom Nov 11, 2024
08ff664
fix only images case
stanislawpuda-tomtom Nov 11, 2024
e0030d9
cleaning + update render tests
stanislawpuda-tomtom Nov 11, 2024
00a0acf
Merge branch 'main' of https://github.com/tomtom-forks/maplibre-gl-js…
stanislawpuda-tomtom Jan 21, 2025
e9f5cef
bump maplibre-style-spec version
stanislawpuda-tomtom Jan 21, 2025
73bb772
update bundle size
stanislawpuda-tomtom Jan 21, 2025
c0291d9
use style spec type
stanislawpuda-tomtom Jan 21, 2025
d3c3040
fix verticalAlign rendering tests
stanislawpuda-tomtom Jan 21, 2025
fdec2e3
Merge branch 'main' of https://github.com/tomtom-forks/maplibre-gl-js…
stanislawpuda-tomtom Jan 22, 2025
83472aa
improve justifyLine readabilty
stanislawpuda-tomtom Jan 22, 2025
94bdeb4
refactor getRectAndMetrics
stanislawpuda-tomtom Jan 22, 2025
70ff714
use switch in getVerticalAlignFactor
stanislawpuda-tomtom Jan 22, 2025
b87ecdd
split calculateLineContentSize fn to improve readability
stanislawpuda-tomtom Jan 22, 2025
5e08451
Revert "split calculateLineContentSize fn to improve readability"
stanislawpuda-tomtom Jan 22, 2025
7db8e4a
clearing
stanislawpuda-tomtom Jan 22, 2025
1963f38
improve calculateLineContentSize return type
stanislawpuda-tomtom Jan 24, 2025
e2349d7
move isVertical outside shaping fn
stanislawpuda-tomtom Jan 24, 2025
2f60ec5
remove redundant imageName variable
stanislawpuda-tomtom Jan 24, 2025
0a2f966
small shapeLines code simplification
stanislawpuda-tomtom Jan 24, 2025
73afb95
split shapeLines fn
stanislawpuda-tomtom Jan 24, 2025
9744d0f
Merge branch 'main' of https://github.com/tomtom-forks/maplibre-gl-js…
stanislawpuda-tomtom Jan 24, 2025
84b8d8a
fix lint
stanislawpuda-tomtom Jan 24, 2025
98f62d5
add tests for vertical align
stanislawpuda-tomtom Jan 27, 2025
8accb03
fix lint in test file
stanislawpuda-tomtom Jan 27, 2025
8f03ddc
move type definitions to the top of the file
stanislawpuda-tomtom Jan 28, 2025
58437d3
simplify shapeLines adding sectionAttributes object
stanislawpuda-tomtom Jan 28, 2025
1946d51
add return type to TaggedString.getMaxImageSize
stanislawpuda-tomtom Jan 28, 2025
3354e60
Merge branch 'main' of https://github.com/tomtom-forks/maplibre-gl-js…
stanislawpuda-tomtom Jan 28, 2025
61924cf
add changelog
stanislawpuda-tomtom Jan 28, 2025
5b713cf
Merge branch 'main' of https://github.com/tomtom-forks/maplibre-gl-js…
stanislawpuda-tomtom Jan 28, 2025
6760505
update render test files "baseline" -> "bottom"
stanislawpuda-tomtom Jan 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
298 changes: 224 additions & 74 deletions src/symbol/shaping.ts

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/build/min.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ describe('test min build', () => {
const decreaseQuota = 4096;

// feel free to update this value after you've checked that it has changed on purpose :-)
const expectedBytes = 908628;
const expectedBytes = 909795;

expect(actualBytes).toBeLessThan(expectedBytes + increaseQuota);
expect(actualBytes).toBeGreaterThan(expectedBytes - decreaseQuota);
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading