Publish an unminified prod build #4265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4265 +/- ##
==========================================
- Coverage 87.66% 87.62% -0.04%
==========================================
Files 242 242
Lines 33081 33081
Branches 2154 2175 +21
==========================================
- Hits 28999 28987 -12
+ Misses 3111 3106 -5
- Partials 971 988 +17 ☔ View full report in Codecov by Sentry. |
|
Looking at the thread I still don't see the need for an unminified production version. |
HarelM
approved these changes
Jun 13, 2024
|
cc @archmoj - If plotly.js at some point move to typescript, there might be a future where users can get an even better way to explore the source through Isolated Declarations - https://marvinh.dev/blog/speeding-up-javascript-ecosystem-part-10/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few years ago the unminified production build was removed from the build pipeline as part of a larger cleanup.
It's recently been requested to re-introduce it, which is done in this PR.
The build is named like in the past:
dist/maplibre-gl-unminified.js.