Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Autoprefixer postcss Plugin #4165

Merged
merged 4 commits into from
May 24, 2024

Conversation

coliff
Copy link
Contributor

@coliff coliff commented May 24, 2024

Fixes: #4157

Confirmed this is working as expected. The generated CSS in dist for user-select includes this now:

  -webkit-user-select: none;
  -moz-user-select: none;
  user-select: none;

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

Fixes: #4157

Confirmed this is working as expected. The generated CSS for user-select includes this now:
```css
  -webkit-user-select: none;
  -moz-user-select: none;
  user-select: none;
```
@coliff coliff marked this pull request as ready for review May 24, 2024 09:15
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.54%. Comparing base (57716b0) to head (9c0ee27).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4165      +/-   ##
==========================================
+ Coverage   86.52%   86.54%   +0.02%     
==========================================
  Files         242      242              
  Lines       33071    33071              
  Branches     2031     2034       +3     
==========================================
+ Hits        28614    28621       +7     
- Misses       3466     3469       +3     
+ Partials      991      981      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit 5dadafb into maplibre:main May 24, 2024
15 checks passed
@coliff coliff deleted the dev/coliff/autoprefixer-postcss branch May 24, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add autoprefixer postcss Plugin
3 participants