Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scale control default parameters #4002

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Apr 15, 2024

Before this CL, the following would generate an error:

const scaleCtrl = new ScaleControl():

because options is not marked as optional.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@HarelM
Copy link
Collaborator

HarelM commented Apr 15, 2024

Can you please add a changelog item?

@vicb vicb force-pushed the ml/scalecontrol branch from 925c0bf to 4255877 Compare April 15, 2024 16:42
@vicb
Copy link
Contributor Author

vicb commented Apr 15, 2024

@HarelM thanks for the quick feedback. Done.

Before this CL, the following would generate an error:

```ts
const scaleCtrl = new ScaleControl():
```

because options is not marked as optional.
@vicb vicb force-pushed the ml/scalecontrol branch from 4255877 to f74d038 Compare April 15, 2024 17:11
@vicb
Copy link
Contributor Author

vicb commented Apr 15, 2024

Done.
It would be nice to switch to something like conventional change logs to auto generate the change log

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 62.77%. Comparing base (da9ac17) to head (f74d038).
Report is 5 commits behind head on main.

Files Patch % Lines
src/ui/control/scale_control.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4002       +/-   ##
===========================================
- Coverage   86.89%   62.77%   -24.12%     
===========================================
  Files         242      239        -3     
  Lines       32483    32255      -228     
  Branches     2126     1468      -658     
===========================================
- Hits        28226    20248     -7978     
- Misses       3328    11228     +7900     
+ Partials      929      779      -150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Collaborator

HarelM commented Apr 15, 2024

Feel free to push this auto changelog forward, I didn't find something that is easy enough to use and is clear how the commit messages should look in order for it to work properly...
But I might haven't searched enough.

@HarelM HarelM enabled auto-merge (squash) April 15, 2024 19:57
@HarelM HarelM merged commit d76c044 into maplibre:main Apr 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants