-
-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scale control default parameters #4002
Conversation
Can you please add a changelog item? |
@HarelM thanks for the quick feedback. Done. |
Before this CL, the following would generate an error: ```ts const scaleCtrl = new ScaleControl(): ``` because options is not marked as optional.
Done. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4002 +/- ##
===========================================
- Coverage 86.89% 62.77% -24.12%
===========================================
Files 242 239 -3
Lines 32483 32255 -228
Branches 2126 1468 -658
===========================================
- Hits 28226 20248 -7978
- Misses 3328 11228 +7900
+ Partials 929 779 -150 ☔ View full report in Codecov by Sentry. |
Feel free to push this auto changelog forward, I didn't find something that is easy enough to use and is clear how the commit messages should look in order for it to work properly... |
Before this CL, the following would generate an error:
because options is not marked as optional.
Launch Checklist
CHANGELOG.md
under the## main
section.