-
-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update popup methods addClass / removeClass to return popup instance #3975
Conversation
Return `this` (popup instance) one the `addClass` / `removeClass` methods.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3975 +/- ##
==========================================
+ Coverage 86.24% 86.45% +0.20%
==========================================
Files 242 242
Lines 32515 32517 +2
Branches 2156 2145 -11
==========================================
+ Hits 28042 28111 +69
+ Misses 3507 3450 -57
+ Partials 966 956 -10 ☔ View full report in Codecov by Sentry. |
Thanks for taking the time to open this PR! |
Sorry, have seen this, it's not forgotten :D Will come back to this during this week 🙇🏿 Sorry for the caused inconvenience |
@HarelM, would you kindly have another look thanks 🙇🏿 |
As mentioned in discussion #3972
Launch Checklist
CHANGELOG.md
under the## main
section.