Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addLayer() typing to allow adding a source with a layer #2966

Merged
merged 8 commits into from
Aug 11, 2023

Conversation

neodescis
Copy link
Collaborator

@neodescis neodescis commented Aug 9, 2023

Closes #2442.

Tweaks the typing for map.addLayer() and style.addLayer() to allow adding a source with the layer.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@neodescis neodescis changed the title Fix add layer typing Fix addLayer() typing to allow adding a source with a layer Aug 9, 2023
@HarelM
Copy link
Collaborator

HarelM commented Aug 10, 2023

Adde some nit picking, otherwise looks good.

@neodescis
Copy link
Collaborator Author

Nit picking appreciated. I added a changelog entry as well.

@HarelM
Copy link
Collaborator

HarelM commented Aug 10, 2023

There are still lint warning... Can you fix those?

@neodescis
Copy link
Collaborator Author

Sorry, missed removing imports after consolidating the type to AddLayerObject. Should be fixed now.

@HarelM HarelM merged commit 4879e34 into maplibre:main Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants