-
-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix addLayer() typing to allow adding a source with a layer #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neodescis
commented
Aug 9, 2023
neodescis
commented
Aug 9, 2023
neodescis
commented
Aug 9, 2023
HarelM
reviewed
Aug 10, 2023
Adde some nit picking, otherwise looks good. |
Nit picking appreciated. I added a changelog entry as well. |
There are still lint warning... Can you fix those? |
Sorry, missed removing imports after consolidating the type to AddLayerObject. Should be fixed now. |
HarelM
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2442.
Tweaks the typing for map.addLayer() and style.addLayer() to allow adding a source with the layer.
Launch Checklist
CHANGELOG.md
under the## main
section.