Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bms,ladfile_builder): introduce app global instance registry and export them in ladfile_builder #340

Merged
merged 8 commits into from
Mar 3, 2025

Conversation

makspll
Copy link
Owner

@makspll makspll commented Mar 2, 2025

Summary

  • Adds AppScriptGlobalRegistry
  • Pushes responsibility of registering globals up to BMS core
  • Does not cover all globals, as entity, world and script_id have more complex requirements, these will be taken care of later, probably by being moved to actual functions (which will also avoid needlessly allocating entities)
  • Makes ladfile_builder export globals to the ladfile format as defined earlier
  • This is now visible in the global docs
  • Also adds script_globals derive macro, but I am not sure how useful that's going to be

image

addresses: #322

@makspll makspll enabled auto-merge (squash) March 2, 2025 21:08
@makspll makspll merged commit 72cb3ba into main Mar 3, 2025
15 of 16 checks passed
@makspll makspll deleted the feat/lad-globals branch March 3, 2025 12:38
@github-actions github-actions bot mentioned this pull request Mar 3, 2025
This was referenced Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant