Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eso-flames-fposs: new port #27711

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JohnPritchard
Copy link

@JohnPritchard JohnPritchard commented Feb 18, 2025

Description

New Portfile eso-flames-fposs
FPOSS is the Observation preparation Software for the FLAMES instrument on the European Southern Observatory's Very large telescope.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.3.1 24D70 arm64
Xcode 16.2 16C5032a

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install? port -vst install fails, but port -vs install succeeds.
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@JohnPritchard
Copy link
Author

A little additional information via references.

You can find out about the European Southern Observatory here, the Very Large Telescope here, the instrument FLAMES here and the FPOSS software here.

@JohnPritchard JohnPritchard changed the title new Portfile eso-flames-fposs eso-flames-fposs: new port Mar 5, 2025
@JohnPritchard
Copy link
Author

JohnPritchard commented Mar 7, 2025

@ryandesign , via email:

On 5/3/2025 20:18, Ryan Carsten Schmidt wrote:

On Mar 5, 2025, at 02:38, John Pritchard wrote:
I submitted a pull request for a first new port (eso-flames-fpos, see #27711 <https:// github.com/macports/macports-ports/pull/27711>) two weeks ago, but so far nothing has happened. Is there something I need to do to get things moving?

Sorry, I haven't been following the pull requests lately and didn't see it.
Looking at it now, I have several suggestions for changes, which I will try to write up in the PR later today.

In the meantime, let me add, as discussed with the MacPorts Management Team, in particular with jmroot, this is a first package in what will be a series of packages for European Southern Observatory [ESO] software. Ultimately upto ~200 individual packages, some which rely on a "legacy" software stack (tcl/tk-8.4), and others which have a conflicts with some existing packages. Hence the desire to keep all these packages "isolated" in /opt/local/libexec/eso. This particular package doesn't really need this, but I think it will be best/easiest to manage in the long term to be consistent for all the ESO packages.

This may help explain some of the choices in the Portfile that you were perhaps going to suggest to change.

Of course, I am happy to discuss all this in more detail.

@JohnPritchard
Copy link
Author

Ok, good, I see that the minor change I just made, to modify the "prefix" install dir from:
${prefix}/libexec/eso-flames-fposs
to
${prefix}/libexec/eso
is noted here in this ticket. Cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants