-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
halloy: update to 2025.1 #27698
base: master
Are you sure you want to change the base?
halloy: update to 2025.1 #27698
Conversation
@cvengler This fails everywhere on the CI - please check. |
beeca1c
to
bc3cbc8
Compare
@reneeotten I believe CI will pass now. |
darling_core 0.14.4 109c1ca6e6b7f82cc233a97004ea8ed7ca123a9af07a8230878fcfda9b158bf0 \ | ||
darling_core 0.20.10 95133861a8032aaea082871032f5815eb9e98cef03fa916ab4500513994df9e5 \ | ||
darling_macro 0.14.4 a4aab4dbc9f7611d8b55048a3a16d2d010c2c8334e46304b40ac1cc14bf3b48e \ | ||
darling_macro 0.20.10 d336a2a514f6ccccaa3e09b02d41d35330c07ddf03a62165fcec10bb561c7806 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there seem to be duplicates in the list here - is that intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is generated automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's all great but it doesn't seem correct...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous list was not any different. Besides, it is correct because different crates use different versions of the same crates. This works without problems usually, as long as those crates do not re-export any types used by these crates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the cargo.crates
list is generated from a Rust project's Cargo.lock
file (which itself derives from the Cargo.toml
file).
It's quite common to see more than one version of the same crate in a Rust project's dependencies list.
This is possible for a number of reasons, one of them being that some other dependency crates may each themselves use different versions of the same root level crate.
You can see entries for the 2 versions of darling_core
here and here.
So I think we're fine here.
ping @herbygillot |
Responded above. Also @cvengler, |
No description provided.