Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify seconds for the timeout parameter #856

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

hoylemd
Copy link
Contributor

@hoylemd hoylemd commented Jul 30, 2018

Tiny doc change - The Requests module's docstrings mention that timeout should be in seconds, but it's unclear here.

Tiny doc change - The Requests module's docstrings mention that `timeout` should be in seconds, but it's unclear here.
Copy link
Member

@cgoldberg cgoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 30, 2018

Codecov Report

Merging #856 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #856   +/-   ##
=======================================
  Coverage   66.55%   66.55%           
=======================================
  Files          14       14           
  Lines        1438     1438           
  Branches      226      226           
=======================================
  Hits          957      957           
  Misses        430      430           
  Partials       51       51
Impacted Files Coverage Δ
locust/clients.py 96.62% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133ad8f...4cc0e4d. Read the comment docs.

@aldenpeterson-wf aldenpeterson-wf merged commit a13864f into locustio:master Jul 30, 2018
@aldenpeterson-wf
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants