Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bounds are incorrect for items in the 3rd quadrant #202

Closed
brollb opened this issue Feb 4, 2016 · 0 comments
Closed

Bounds are incorrect for items in the 3rd quadrant #202

brollb opened this issue Feb 4, 2016 · 0 comments
Labels
bug

Comments

@brollb
Copy link
Contributor

brollb commented Feb 4, 2016

If an item is entirely in the 3rd quadrant (that is, all it's coordinates are negative), the bounds value is incorrect. Specifically, the max value for the bounds will be set to a number marginally above 0 (Number.MIN_VALUE)
brollb added a commit to brollb/matter-js that referenced this issue Feb 4, 2016
@brollb
Changed bounds checking MIN_VALUE to -MAX_VALUE. Fixes liabru#202
123d548
@liabru liabru added the bug label Feb 4, 2016
@liabru liabru closed this as completed in dd5e260 Feb 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liabru @brollb