Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix of issue #11 #25

Merged
merged 1 commit into from
Jan 1, 2020
Merged

fix of issue #11 #25

merged 1 commit into from
Jan 1, 2020

Conversation

MarkChenYutian
Copy link

@MarkChenYutian MarkChenYutian commented Jan 1, 2020 •
edited
Loading

  1. added gatsby-remark-autolink-headers, which correctly sets id
    attributes of headers
  2. changed rightSidebar.js to use url instead of title for anchors

@MarkChenYutian MarkChenYutian changed the title temporary fix of issue #11 fix of issue #11 Jan 1, 2020
@Mr-Wiredancer
fix issue #11
0d43d77 
1. added `gatsby-remark-autolink-headers`, which correctly sets `id`
attributes of headers
2. changed `rightSidebar.js` to use `url` instead of `title` for anchors
@agentmilindu
Copy link
Collaborator

This looks good for me, good job!

@agentmilindu
Copy link
Collaborator

Fix #11

@agentmilindu agentmilindu requested a review from apoorvam January 1, 2020 17:07
@apoorvam apoorvam merged commit b73761b into leopardslab:develop Jan 1, 2020
@apoorvam
Copy link
Collaborator

apoorvam commented Jan 2, 2020

@MarkChenYutian Do you see any changes in package-lock.json file that reflect your addition of new package? That would fix the CI build pipeline: https://travis-ci.org/leopardslab/dunner-website/builds/631612608?utm_source=github_status&utm_medium=notification

If you run npm locally and see if there is a change, send another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvam apoorvam apoorvam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarkChenYutian @agentmilindu @apoorvam @Mr-Wiredancer