gen: fix implicit vector cast in binary operations #4780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liushuyu
force-pushed
the
fix-implicit-vector-cast
branch
2 times, most recently
from
3c1306c to
a394911
Compare
liushuyu
force-pushed
the
fix-implicit-vector-cast
branch
from
a394911 to
309c8e8
Compare
|
Alternative frontend fix: #4781 |
Ah I see, then I will close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes implicit vector cast in binary operations. Rather than standard integer extension, vector casts require the RHS (right-hand side) to be a vector of matching size. In this patch, a vector splat operation fills the target vector type with the original value across all the lanes/elements.
This should fix #3606.