[12.x] Changed whereRelation to work with only two params when the $column variable is not instance of \Closure

[habibendris]

The Eloquent whereRelation accepts 4 parameters in total $relation, $column, $operator = null, $value = null

So whenever we want to query we have to use the whereRelation as follows.

$posts = Post::query()
    ->whereRelation('comments', 'user_id', Auth::id())
    ->get()

We always have to use atleast 3 parameters if the $column is not instance of \Closure.
This pull request allows us to only use 2 parameters for this usecase.

$posts = Post::query()
    ->whereRelation('comments.user_id', Auth::id())
    ->get()

[shaedrich]

The title of your PR is a little misleading as whereRelation() does indeed work with just two params since the latter two are both optional. It just doesn't for your use case, but it does for when you want to check if the value is null. So I would rename your PR to something like "Add dot notation support to whereRelation".

[macropay-solutions]

To avoid breaking change, the column variable can stay the same and just the dockblock would need changing.

[habibendris]

To avoid breaking change, the column variable can stay the same and just the dockblock would need changing.

I have updated the commit as needed

[mohammadrasoulasghari]

Fixed the StyleCI issue by removing additional spaces in the line. 🧹
issue link

Let all the checks pass.👌

[taylorotwell]

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!