[DB-Test] Assert different number of types in pgsql 10 #52638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Jubeki
changed the title
taylorotwell
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Add MSSQL 2017 and PGSQL 10 builds * Update databases.yml * Skip Tests (#52632) * [DB-Test] Assert different number of types in pgsql 10 (#52638) * Find out which types are not counted * dump types * Bypass count check for pgsql 10 --------- Co-authored-by: Julius Kiekbusch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on some testing, it seems some types with an
_prefix are generated additionally. Everything else the test case checks passes. I therefor opted, for simply changing the asserted count. (I did not test the count with the different pgsql versions, therefor simply choosing the bound< 14.0)