chore: Fix execute not start vt issue. #39
Conversation
| override def execute(body: Runnable): Unit = VTFactory.newThread(body) | ||
| override def execute(body: Runnable): Unit = | ||
| val th = VTFactory.newThread(body) | ||
| th.start() |
There was a problem hiding this comment.
@m8nmueller I forgot to start it, sorry~~
|
Can you add a test to make sure things work as expected? |
|
Sorry, I still can't build the snapshot out locally, and a little busy at work. cherry pick if you like. Sorry for missed the |
|
No worries, I'll add a test onto your branch.
Did you run into problems running |
|
I'm using Windows 11, so I didn't |
natsukagami
force-pushed
the
fixExecute
branch
from
8ec048f to
7494d8b
Compare
|
Sorry for the force-push, I wanted to rebase it to the latest upstream main branch |
|
@natsukagami Thanks I want to learn how to force push to a contributor branch too |
As long as "Maintainers are allowed to edit this pull request." I think regular |
|
@natsukagami I can't install the github cli, company doesn't allow it. thank you ,just learn something new |
Motivation:
In my last pr, I forgot to start the VT :(
Result:
Fixed :)