-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stav: extract information for the prover from the runner #1982
base: main
Are you sure you want to change the base?
Conversation
596fab9
to
9db0939
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @fmoletta, @gabrielbosio, @igaray, @juanbono, @Oppen, @pefontana, and @yuvalsw)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @fmoletta, @gabrielbosio, @igaray, @juanbono, @Oppen, @pefontana, and @yuvalsw)
vm/src/vm/runners/cairo_runner.rs
line 1495 at r3 (raw file):
public_memory_offsets: self.vm.segments.public_memory_offsets.iter() .map(|(segment, offset_page)| { let offsets: Vec<usize> = offset_page.iter().map(|(offset, _)| *offset).collect();
what is the data that you are deleting? why don't you need it? does it mean you can have duplications in offsets
?
vm/src/vm/runners/cairo_runner.rs
line 1507 at r3 (raw file):
//* ProverInfo //* ---------------------- /// This struct contains all relevant data for the prover.
delete spaces at end of line (also below)
9db0939
to
4fd88b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @DavidLevitGurevich, @fmoletta, @gabrielbosio, @igaray, @juanbono, @Oppen, @pefontana, and @yuvalsw)
vm/src/vm/runners/cairo_runner.rs
line 1495 at r3 (raw file):
Previously, DavidLevitGurevich wrote…
what is the data that you are deleting? why don't you need it? does it mean you can have duplications in
offsets
?
I am deleting the page id, which " it's just a logical overlay on the output, it's relevant for apps/bootloaders" according to Titelman.
I can't have duplications because of it.
4fd88b8
to
5ef52df
Compare
5ef52df
to
05a3f6f
Compare
Add ProverInfo struct and create it from the runner
In contrast to how we did it before, we want to use the data while it's still relocatable and perform the relocation in the adapter. For this, we need the memory, trace, built-in segment information, and public memory addresses before they are relocated.
Checklist
This change is