-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Dockerfile): openssh-client support #9835
Conversation
Hi @maxime1907. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I coud not find a git history which contained openssh-client on the Dockerfile. |
@oomichi its because we recently added a flag You can see it happened to others here too: |
Thank you for your explanation, I see that. /ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxime1907, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@maxime1907 Could you rebase this pull request to solve a conflict? |
@oomichi done! |
Thanks @maxime1907 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
openssh-client was present before this MR.
This simple commit adds it back as it let us manage ssh connections that require a private/public key instead of a password with sshpass.
Does this PR introduce a user-facing change?: