Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cri-dockerd log level configurable #11646

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Make cri-dockerd log level configurable #11646

merged 1 commit into from
Oct 21, 2024

Conversation

mirwan
Copy link
Contributor

@mirwan mirwan commented Oct 17, 2024 •
edited by k8s-ci-robot
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
cri-dockerd does log by default at the "info" level which may generate lots of log lines.
This PR makes the log level configurable, leaving the current behaviour unchanged by setting the "info" as the default for the corresponding Ansible variable.

Which issue(s) this PR fixes:
None that I know of

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Make cri-dockerd log level configurable

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 17, 2024
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mirwan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tico88612
tico88612 reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable naming.

@tico88612
Copy link
Member

/kind feature
/release-note-edit

Make cri-dockerd log level configurable

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 18, 2024
@mirwan
Copy link
Contributor Author

mirwan commented Oct 18, 2024

@tico88612 Thx for the review, I took into account your suggestions. Should I squash myself or is it done upon merge ?

@yankay
Copy link
Member

yankay commented Oct 18, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 18, 2024
@tico88612
Copy link
Member

tico88612 commented Oct 18, 2024 •
edited
Loading

@mirwan Yes, please squash this to one commit.

@mirwan mirwan force-pushed the make_cridockerd_loglevel_configurable branch from 6fd098e to 38ce0c6 Compare October 18, 2024 06:44
@mirwan
Copy link
Contributor Author

mirwan commented Oct 18, 2024 via email •
edited
Loading

tico88612
tico88612 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2024
@VannTen
Copy link
Contributor

VannTen commented Oct 21, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mirwan, tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit daa9411 into kubernetes-sigs:master Oct 21, 2024
40 checks passed
@tico88612 tico88612 mentioned this pull request Nov 27, 2024
Closed
kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
@mirwan @kpoxo6op
Make cri-dockerd log level configurable (kubernetes-sigs#11646)
918445b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico88612 tico88612 tico88612 approved these changes

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

Assignees

@tico88612 tico88612

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mirwan @k8s-ci-robot @tico88612 @yankay @VannTen