Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.25] Fix CI fail with download_localhost #11382

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[release-2.25] Fix CI fail with download_localhost #11382

merged 1 commit into from
Jul 19, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #11315

/assign tico88612

Fix CI with fail docker pull in gitlab runner by change DOCKER_HOST

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 15, 2024
Merged
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 15, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 15, 2024
@k8s-ci-robot k8s-ci-robot requested a review from ErikJiang July 15, 2024 12:22
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 15, 2024
@k8s-ci-robot k8s-ci-robot requested a review from MrFreezeex July 15, 2024 12:22
@tico88612
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2024
@tico88612
Copy link
Member

@yankay @mzaian PTAL, thanks!

mzaian
mzaian approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit a78d5e7 into kubernetes-sigs:release-2.25 Jul 19, 2024
78 checks passed
@robertvolkmann
Copy link
Contributor

/kind failing-test

@k8s-ci-robot k8s-ci-robot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Oct 10, 2024
@robertvolkmann robertvolkmann mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian mzaian approved these changes

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

@MrFreezeex MrFreezeex Awaiting requested review from MrFreezeex

Assignees

@mzaian mzaian

@tico88612 tico88612

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@k8s-infra-cherrypick-robot @tico88612 @k8s-ci-robot @robertvolkmann @mzaian @yankay