Rename iscsi to iSCSI #260
Conversation
k8s-ci-robot
added
release-note-none
| @@ -30,12 +30,12 @@ Set-ItemProperty -Path "HKLM:\SOFTWARE\Microsoft\iSCSI Target" -Name AllowLoopBa | |||
| Restart-Service WinTarget | |||
| ` | |||
|
|
|||
| type IscsiSetupConfig struct { | |||
| type iSCSISetupConfig struct { | |||
There was a problem hiding this comment.
I think this is different in Go, if it starts with uppercase then it's not exported in the package, with this change this becomes private to the package only, is this intended and ok?
There was a problem hiding this comment.
I checked that this is just for the tests so I think it's ok to make it private (even better than what it's now)
There was a problem hiding this comment.
I saw this in the logs:
=== RUN TestISCSI
utils.go:31: Skipping test
--- SKIP: TestISCSI (0.00s)
I don't think I ever saw these tests running (even before CSI Proxy became GA), looks like this function func shouldRunISCSITests() bool controls running the tests.
Before merging this, would it be possible to enable these tests too?
I thought the iSCSI tests leave side effects and therefore should be run on clean VMs, so they are controlled by an environment variable. What do we want to do here? We could enable this on GitHub actions easily, but the Prow job runs by executing |
alexander-ding
force-pushed
the
enh/rename-api-groups
branch
from
b4312f3 to
219b990
Compare
|
Sorry about the force-push. Accidentally pushed another commit onto this branch that is not meant for this PR. Had to reset that with a force-push. |
|
These tests are for an alpha version and I didn't get to see them running, it's good to track it in #263 and someone with experience with this API group can help moving it to beta. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-ding, mauriciopoppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
alexander-ding
force-pushed
the
enh/rename-api-groups
branch
from
faf088b to
219b990
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
98f2307 Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version e9d8712 Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root faf79ff Remove --kube-root deprecated kind argument 734c2b9 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch f95c855 Merge pull request kubernetes-csi#262 from huww98/golang-toolchain 3c8d966 Treat main branch as equivalent to master branch e31de52 Merge pull request kubernetes-csi#261 from huww98/golang fd153a9 Bump golang to 1.23.1 a8b3d05 pull-test.sh: fix "git subtree pull" errors 6b05f0f use new GOTOOLCHAIN env to manage go version 18b6ac6 chore: update CSI driver version to 1.15 git-subtree-dir: release-tools git-subtree-split: 98f23071d946dd3de3188a7e1f84679067003162
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Improve naming consistency and adhere to Go best practices (using all caps when the name contains acronyms).
Which issue(s) this PR fixes:
Fixes #248
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Deferring release notes till version bump.
/cc @mauriciopoppe