-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sure gw pod exist before eip creation #4924
Conversation
Pull Request Test Coverage Report for Build 12800143555Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
thanks for this. I think this will prevent the leak when the EIP is misconfigured. There's still the risk that the nat gateway is broken in some way and the exec in pod fails which may cause the IP to leak but that's more of an edge case |
yeah, if the pod crashes, and can not run up later, the EIP is leaked. how about talking about theses cases in detail later, we will try to help fix them too. |
f7968a0
to
e2b51ef
Compare
@oilbeater 这个ut降低跟这个pr应该也没关系 |
Signed-off-by: zbb888 <[email protected]>
e2b51ef
to
df1ea7e
Compare
Signed-off-by: zbb888 <[email protected]>
Pull Request
What type of this PR
Examples of user facing changes:
#4922
Which issue(s) this PR fixes
Fixes #(issue-number)