-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for MXJob #2150
Remove support for MXJob #2150
Conversation
19e94ed
to
fef7ee7
Compare
Pull Request Test Coverage Report for Build 9655675174Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9655678457Details
💛 - Coveralls |
Thank you for working on this @tariq-hasan! |
I think, we should be ready to merge it since Training Operator 1.8 was released. |
69b8ac4
to
fef7ee7
Compare
Pull Request Test Coverage Report for Build 10121292822Details
💛 - Coveralls |
fef7ee7
to
6173d7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm |
Looking into the failed integration tests now. |
6173d7e
to
c746938
Compare
Signed-off-by: tariq-hasan <[email protected]>
c746938
to
57ad42a
Compare
/rerun-workflow "integration test" |
I updated manifests/base/webhook/patch.yaml to fix the integration tests. If we re-run the integration tests all of them should pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
This PR addresses the deprecation of MXJob from Training Operator.
Related PR: #1953
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #1996
Checklist: