v1alpha2: Add API and codegen

[gaocegege]

Signed-off-by: Ce Gao [email protected]

---

This change is 

[coveralls]

Coverage increased (+1.8%) to 47.037% when pulling 87848e3 on gaocegege:api/v1alpha2 into 0704e24 on kubeflow:master.

[mitake]

@gaocegege this PR itself seems good to me. Do you already have tf-operator side changes?

[gaocegege]

@mitake

We are going to split the changes into different PRs and this one is for API 😄

/assign @jlewi @mitake

[mitake]

@gaocegege ok, then this PR looks good to me :)

[jlewi]

Review status: 0 of 28 files reviewed at latest revision, all discussions resolved.

---

pkg/apis/tensorflow/v1alpha2/types.go, line 71 at r2 (raw file):

	// Restart policy for all TFReplicas within the TFJob.
	// One of Always, OnFailure, Never and ExitCode.
	// Default to Always.

Not sure a default of Always really make sense; you wouldn't want to restart the master on success. Could we make the policy required?
Or should we have a replica type dependent default? Having a default value that is replica dependent seems a little complicated thogh.

---

pkg/apis/tensorflow/v1alpha2/types.go, line 116 at r2 (raw file):

Represents

Nit "Represents" -> Conditions

---

pkg/apis/tensorflow/v1alpha2/utils.go, line 25 at r2 (raw file):

// Pformat returns a pretty format output of any value that can be marshalled to JSON.
func Pformat(value interface{}) string {

Why is this function in v1alpha2? It doesn't look like anything about this function is specific to a given version.
Can't we have a single Pformat function for all versions?

---

Comments from Reviewable

[gaocegege]

Not sure a default of Always really make sense; you wouldn't want to restart the master on success. Could we make the policy required?
Or should we have a replica type dependent default? Having a default value that is replica dependent seems a little complicated thogh.

This is defined in TFJobReplicasSpec and it should works on a single type. And I agree that always is weird and I think I could open an issue for it. After all PRs merged and I will fix it. WDYT

[gaocegege]

Updated, PTAL

[gaocegege]

Why is this function in v1alpha2? It doesn't look like anything about this function is specific to a given version.
Can't we have a single Pformat function for all versions?

I removed the function and use util package instead.

[jlewi]

Review status: 0 of 27 files reviewed at latest revision, all discussions resolved.

---

pkg/apis/tensorflow/v1alpha2/types.go, line 71 at r2 (raw file):

Previously, jlewi (Jeremy Lewi) wrote…

Not sure a default of Always really make sense; you wouldn't want to restart the master on success. Could we make the policy required?
Or should we have a replica type dependent default? Having a default value that is replica dependent seems a little complicated thogh.

@gaocege commented elsewhere that will resolve this in a follow up issue.

---

Comments from Reviewable

[jlewi]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment