Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sleep and random exit image for e2e test #487

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

ScorpioCPH
Copy link
Member

@ScorpioCPH ScorpioCPH commented Mar 21, 2018

Hi, this PR add an image for e2e test:

  • Run a script that sleep a random seconds.
  • Then exit a random code:
    • Exit 0 means this pod is succeeded.
    • Exit nonzero means this pod is failed.

We can use this image to count active/failed/succeeded pods.

@jlewi @gaocegege PTAL, thanks!


This change is Reviewable

@ScorpioCPH
Copy link
Member Author

/assign @gaocegege

@coveralls
Copy link

coveralls commented Mar 21, 2018

Coverage Status

Coverage remained the same at 60.668% when pulling b06ff7e on ScorpioCPH:v1alpha2-e2e-test into e6d3c73 on kubeflow:v1alpha2.

@gaocegege
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 47d989f into kubeflow:v1alpha2 Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants