Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller: Add check for service and fix service #482

Merged
merged 3 commits into from
Mar 21, 2018
Merged

controller: Add check for service and fix service #482

merged 3 commits into from
Mar 21, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Mar 20, 2018


This change is Reviewable

@coveralls
Copy link

coveralls commented Mar 20, 2018

Coverage Status

Coverage increased (+1.6%) to 60.668% when pulling 1c2b690 on gaocegege:service into 280f77c on kubeflow:v1alpha2.

@gaocegege
Copy link
Member Author

/hold cancel
/assign @ScorpioCPH

Copy link
Member

@ScorpioCPH ScorpioCPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScorpioCPH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e6d3c73 into kubeflow:v1alpha2 Mar 21, 2018
@gaocegege gaocegege deleted the service branch March 21, 2018 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants