Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use headless services for Training jobs #471

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

rc-zhang
Copy link
Contributor

@rc-zhang rc-zhang commented Mar 19, 2018

ref #40

cc @gaocegege


This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from lluunn and zjj2wry March 19, 2018 06:58
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@coveralls
Copy link

coveralls commented Mar 19, 2018

Coverage Status

Coverage increased (+0.2%) to 44.647% when pulling 384fc02 on rc-zhang:headless_svc into a36b350 on kubeflow:master.

@googlebot
Copy link

CLAs look good, thanks!

@gaocegege
Copy link
Member

gaocegege commented Mar 19, 2018

Thanks for your contribution!

pkg/trainer/replicas.go:1::warning: file is not goimported (goimports)

Please fix the code style errors reported by travis :-)

@gaocegege
Copy link
Member

/ok-to-test

@rc-zhang
Copy link
Contributor Author

@gaocegege fixed. The issue is I didn't gofmt the file.

@gaocegege
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 771c4f9 into kubeflow:master Mar 21, 2018
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants