Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include TfJob name in labels #72

Closed
jlewi opened this issue Oct 23, 2017 · 0 comments
Closed

Include TfJob name in labels #72

jlewi opened this issue Oct 23, 2017 · 0 comments
Labels
good first issue help wanted

Comments

@jlewi
Copy link
Contributor

jlewi commented Oct 23, 2017

We should include the TfJob name in the labels of all resources. This would make it easy to identify all resources associated with a particular job.

Here is the current set of labels attached to a pod.

labels:
    controller-uid: e5e93fc9-b5e5-11e7-8522-42010a8e01a4
    job-name: master-76no-0
    job_type: MASTER
    mlkube.io: ""
    runtime_id: 76no
    task_index: "0"
@jlewi jlewi mentioned this issue Oct 24, 2017
Merged
jlewi added a commit to jlewi/k8s that referenced this issue Oct 31, 2017
@jlewi
Add Name of the job to the labels.
c52bcf6 
* This will make it easier to fetch resources belonging to a specific job.
* Fixes kubeflow#72.
@jlewi jlewi mentioned this issue Oct 31, 2017
Merged
@jlewi jlewi closed this as completed in #105 Nov 1, 2017
jlewi added a commit that referenced this issue Nov 1, 2017
@jlewi
Name label (#105)
e807068 
Add Name of the job to the labels.

This will make it easier to fetch resources belonging to a specific job.

* Fixes #72.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlewi