fix the same issue in pod and service under TFJobController

kubeflow · Aug 12, 2018 · 62ae492 · 62ae492
1 parent bf74595
commit 62ae492
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/controller.v2/tfcontroller/pod.go b/pkg/controller.v2/tfcontroller/pod.go
@@ -89,7 +89,7 @@ func (tc *TFJobController) reconcilePods(
 				}
 				if pod.Status.Phase == v1.PodFailed && train_util.IsRetryableExitCode(exitCode) {
 					logger.Infof("Need to restart the pod: %s-%d", rt, index)
-					if err := tc.PodControl.DeletePod(pod.Namespace, pod.Name, tfjob); err != nil {
+					if err := tc.JobController.PodControl.DeletePod(pod.Namespace, pod.Name, tfjob); err != nil {
 						return err
 					}
 					restart = true
@@ -171,7 +171,7 @@ func (tc *TFJobController) createNewPod(tfjob *tfv1alpha2.TFJob, rt, index strin
 	}
 	setRestartPolicy(podTemplate, spec)
 
-	err = tc.PodControl.CreatePodsWithControllerRef(tfjob.Namespace, podTemplate, tfjob, controllerRef)
+	err = tc.JobController.PodControl.CreatePodsWithControllerRef(tfjob.Namespace, podTemplate, tfjob, controllerRef)
 	if err != nil && errors.IsTimeout(err) {
 		// Pod is created but its initialization has timed out.
 		// If the initialization is successful eventually, the

diff --git a/pkg/controller.v2/tfcontroller/service.go b/pkg/controller.v2/tfcontroller/service.go
@@ -137,7 +137,7 @@ func (tc *TFJobController) createNewService(tfjob *tfv1alpha2.TFJob, rtype tfv1a
 	service.Name = jobcontroller.GenGeneralName(tfjob.Name, rt, index)
 	service.Labels = labels
 
-	err = tc.ServiceControl.CreateServicesWithControllerRef(tfjob.Namespace, service, tfjob, controllerRef)
+	err = tc.JobController.ServiceControl.CreateServicesWithControllerRef(tfjob.Namespace, service, tfjob, controllerRef)
 	if err != nil && errors.IsTimeout(err) {
 		// Service is created but its initialization has timed out.
 		// If the initialization is successful eventually, the