Skip to content

Commit

Permalink
Reenable cluster teardown.
Browse files Browse the repository at this point in the history
  • Loading branch information
jlewi committed Apr 2, 2018
1 parent c5c8c26 commit 268edd9
Show file tree
Hide file tree
Showing 2 changed files with 57 additions and 5 deletions.
53 changes: 53 additions & 0 deletions releasing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
# Releasing the TFJob operator

Permissions

* You need to be a member of [email protected] to have access to the GCP
resources used for releasing.

* You need write permissions on the repository to create a release branch.


Look at the [postsubmit dashboard](https://k8s-testgrid.appspot.com/sig-big-data#kubeflow-tf-operator-postsubmit)
to find the latest green postsubmit.


Use the GitHub UI to cut a release branch
* Name the release branch v{MAJOR}.${MINOR}-branch

Checkout the release branch

We build TFJob operator by running the E2E test workflow.

Look at the [postsubmit dashboard](https://k8s-testgrid.appspot.com/sig-big-data#kubeflow-tf-operator-postsubmit)
to find the latest green postsubmit.

Check out that commit (in this example, we'll use `6214e560`):

Run the E2E test workflow using our release cluster

[kubeflow/testing#42](https://github.com/kubeflow/testing/issues/42) will simplify this.

```
submit_release_job.sh ${COMMIT}
```

You can monitor the workflow using the Argo UI. For our release cluster, we don't expose the Argo UI publicly, so you'll need to connect via kubectl port-forward:

```
kubectl -n kubeflow-releasing port-forward `kubectl -n kubeflow-releasing get pods --selector=app=argo-ui -o jsonpath='{.items[0].metadata.name}'` 8080:8001
```

[kubeflow/testing#43](https://github.com/kubeflow/testing/issues/43) is tracking setup of IAP to make this easier.

Make sure the Argo workflow completes successfully.
Check the junit files to make sure there were no actual test failures.
The junit files will be in [gs://kubeflow-releasing-artifacts](https://console.cloud.google.com/storage/browser/kubeflow-releasing-artifacts/logs/kubeflow_tf-operator/tf-operator-release/?project=kubeflow-releasing).
* The build artifacts will be in a directory named after the build number

If the tests pass use the GitHub UI to create a release tagged v{MAJOR}-{MINOR}-{PATCH}
* If its an RC append -RC.N
* In the notes create a link to the Docker image in GCR
* For the label use the `sha256` and not the label so it is immutable.

To release new ksonnet configs with the image following [kubeflow/kubeflow/releasing.md](https://github.com/kubeflow/kubeflow/blob/master/releasing.md).
9 changes: 4 additions & 5 deletions test/workflows/components/workflows.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,10 @@
{
name: "exit-handler",
steps: [
// DO NOT SUBMIT comment out to facilitate debugging.
//[{
// name: "teardown-cluster",
// template: "teardown-cluster",
//}],
[{
name: "teardown-cluster",
template: "teardown-cluster",
}],
[{
name: "copy-artifacts",
template: "copy-artifacts",
Expand Down

0 comments on commit 268edd9

Please sign in to comment.