-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the async
keyword argument to async_req
#790
Conversation
The Python Kubernetes client [recently changed](kubernetes-client/python#568) the name of the `async` keyword parameter in its API to `async_req`. This change makes the corresponding change to our calls to that API, which is necessary for the tf-operator code to work against the latest version of the Kubernetes client code.
/assign @gaocegege |
It seems that I need to update the pipenv as well as part of this change. Version 7.0.0 of the |
/retest |
This also updates the outdated dependencies in the Pipfile.lock file.
/retest |
1 similar comment
/retest |
@jlewi Would you help to have a look, Thanks! |
/retest |
I've pushed a new test worker image: |
/test all |
/retest |
@jlewi |
Yes. I have a fix in kubeflow/testing#195 and a new image should be pushed. /test all |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Python Kubernetes client recently changed the name of the
async
keyword parameter in its API toasync_req
.This change makes the corresponding change to our calls to that API, which is necessary for the tf-operator code to work against the latest version of the Kubernetes client code.
This change is