Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the async keyword argument to async_req #790

Merged
merged 2 commits into from
Aug 23, 2018

Conversation

ojarjur
Copy link
Contributor

@ojarjur ojarjur commented Aug 21, 2018

The Python Kubernetes client recently changed the name of the async keyword parameter in its API to async_req.

This change makes the corresponding change to our calls to that API, which is necessary for the tf-operator code to work against the latest version of the Kubernetes client code.


This change is Reviewable

The Python Kubernetes client [recently changed](kubernetes-client/python#568) the name of the `async` keyword parameter in its API to `async_req`.

This change makes the corresponding change to our calls to that API, which is necessary for the tf-operator code to work against the latest version of the Kubernetes client code.
@ojarjur
Copy link
Contributor Author

ojarjur commented Aug 21, 2018

/assign @gaocegege

@coveralls
Copy link

coveralls commented Aug 21, 2018

Coverage Status

Coverage decreased (-0.07%) to 57.957% when pulling 74639c0 on ojarjur:patch-2 into b5809d5 on kubeflow:master.

@ojarjur
Copy link
Contributor Author

ojarjur commented Aug 21, 2018

It seems that I need to update the pipenv as well as part of this change.

Version 7.0.0 of the kubernetes library is backwards incompatible with previous versions of it. As such, we will need to update our requirements to say kubernetes>=7.0.0 instead of kubernetes>=4.0.0.

@ojarjur
Copy link
Contributor Author

ojarjur commented Aug 21, 2018

/retest

This also updates the outdated dependencies in the Pipfile.lock file.
@ojarjur
Copy link
Contributor Author

ojarjur commented Aug 22, 2018

/retest

1 similar comment
@gaocegege
Copy link
Member

/retest

@ChanYiLin
Copy link
Member

ChanYiLin commented Aug 22, 2018

@jlewi
I think why it failed the presubmit is because our testing still use kubernetes 4.0.0
so I try to update it to 7.0.0 in kubeflow/testing kubeflow/testing#194

Would you help to have a look, Thanks!

@ChanYiLin
Copy link
Member

ChanYiLin commented Aug 23, 2018

/retest
/lgtm

@jlewi
Copy link
Contributor

jlewi commented Aug 23, 2018

I've pushed a new test worker image:
gcr.io/kubeflow-ci/test-worker:v20180822-d8bc7c8-e3b0c4
and tagged it latest.

@jlewi
Copy link
Contributor

jlewi commented Aug 23, 2018

/test all

@gaocegege
Copy link
Member

/retest

@ChanYiLin
Copy link
Member

3 tests failed: /py/prow_test.py, /py/release_test.py, /py/util_test.py.
INFO|2018-08-23T05:00:28|test_py_checks.py:23| Running py_test
INFO|2018-08-23T05:00:28|util.py:41| Running: python /mnt/test-data-volume/kubeflow-tf-operator-presubmit-v1-790-74639c0-968-cda2/src/kubeflow/tf-operator/py/prow_test.py 
cwd=/mnt/test-data-volume/kubeflow-tf-operator-presubmit-v1-790-74639c0-968-cda2/src/kubeflow/tf-operator
INFO|2018-08-23T05:00:28|util.py:56| Subprocess output:

INFO|2018-08-23T05:00:29|util.py:62| Traceback (most recent call last):
INFO|2018-08-23T05:00:29|util.py:62| File "/mnt/test-data-volume/kubeflow-tf-operator-presubmit-v1-790-74639c0-968-cda2/src/kubeflow/tf-operator/py/prow_test.py", line 4, in <module>
INFO|2018-08-23T05:00:29|util.py:62| import mock
INFO|2018-08-23T05:00:29|util.py:62| File "/usr/local/lib/python2.7/dist-packages/mock/__init__.py", line 2, in <module>
INFO|2018-08-23T05:00:29|util.py:62| import mock.mock as _mock
INFO|2018-08-23T05:00:29|util.py:62| File "/usr/local/lib/python2.7/dist-packages/mock/mock.py", line 80, in <module>
INFO|2018-08-23T05:00:29|util.py:62| import funcsigs
INFO|2018-08-23T05:00:29|util.py:62| ImportError: No module named funcsigs

@jlewi
Do we also have to add funcsigs into kubeflow/testing images/Pipfile ?
It seems it has dependency on mock in python2

@jlewi
Copy link
Contributor

jlewi commented Aug 23, 2018

Yes. I have a fix in kubeflow/testing#195 and a new image should be pushed.

/test all

@ChanYiLin
Copy link
Member

/lgtm

@ChanYiLin
Copy link
Member

@ojarjur
Thanks for your contribution!

@jlewi
We successfully pass all the tests.
I think we can merge this PR and other PR can then move forward.
Thanks

@jlewi
Copy link
Contributor

jlewi commented Aug 23, 2018

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants