Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

status: Add test cases for failure #643

Merged
merged 3 commits into from
Jun 13, 2018
Merged

status: Add test cases for failure #643

merged 3 commits into from
Jun 13, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jun 12, 2018 •
edited
Loading

  • Add test cases for chief worker and ps/worker status update.

This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from ddysher and mitake June 12, 2018 14:38
@gaocegege
Copy link
Member Author

/asssign @jlewi

@coveralls
Copy link

coveralls commented Jun 12, 2018 •
edited
Loading

Coverage Status

Coverage increased (+1.0%) to 55.414% when pulling 16176da on gaocegege:test into 2456e44 on kubeflow:master.

@gaocegege
Copy link
Member Author

/assign @jlewi

@gaocegege
Copy link
Member Author

/hold

It will block #638 and #637 , which are more important than this PR

@jlewi
Copy link
Contributor

jlewi commented Jun 13, 2018

nit: Please use a more informative title and PR description; what are you adding test cases for?

@gaocegege gaocegege changed the title status: Add test cases status: Add test cases for failure Jun 13, 2018
jlewi
jlewi reviewed Jun 13, 2018
View reviewed changes
pkg/controller.v2/controller_status.go Outdated
@@ -64,7 +64,7 @@ func (tc *TFJobController) updateStatus(tfjob *tfv1alpha2.TFJob, rtype tfv1alpha
msg := fmt.Sprintf("TFJob %s is successfully completed.", tfjob.Name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the condition for determining success need to be updated? Now that you support chief per your other PRs? I think I saw code in your other PR to handle this so maybe you just need to sync?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this PR has conflicts with other PRs, and I will rebase after other PRs are all merged.

@gaocegege
Copy link
Member Author

/retest

@gaocegege gaocegege changed the title status: Add test cases for failure WIP: status: Add test cases for failure Jun 13, 2018
@gaocegege
Copy link
Member Author

/hold cancel

@gaocegege gaocegege changed the title WIP: status: Add test cases for failure status: Add test cases for failure Jun 13, 2018
@jlewi
Copy link
Contributor

jlewi commented Jun 13, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a310cb9 into kubeflow:master Jun 13, 2018
@gaocegege gaocegege deleted the test branch June 14, 2018 01:22
yph152 pushed a commit to yph152/tf-operator that referenced this pull request Jun 18, 2018
@gaocegege
status: Add test cases for failure (kubeflow#643)
9c13dfd 
* pkg: Update

Signed-off-by: Ce Gao <[email protected]>

* status: Add unit test when pod is failed

Signed-off-by: Ce Gao <[email protected]>

* status: Test chief and ps/worker

Signed-off-by: Ce Gao <[email protected]>
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
@gaocegege @k8s-ci-robot
status: Add test cases for failure (kubeflow#643)
b2ce587 
* pkg: Update

Signed-off-by: Ce Gao <[email protected]>

* status: Add unit test when pod is failed

Signed-off-by: Ce Gao <[email protected]>

* status: Test chief and ps/worker

Signed-off-by: Ce Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi left review comments

@ddysher ddysher Awaiting requested review from ddysher

@mitake mitake Awaiting requested review from mitake

Assignees

@jlewi jlewi

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaocegege @coveralls @jlewi @k8s-ci-robot