Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist_mnist: Add unused_argv #604

Merged
merged 1 commit into from
May 23, 2018
Merged

dist_mnist: Add unused_argv #604

merged 1 commit into from
May 23, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented May 22, 2018

Fix #588

Signed-off-by: Ce Gao [email protected]


This change is Reviewable

@gaocegege
Copy link
Member Author

/assign @ScorpioCPH

@coveralls
Copy link

coveralls commented May 22, 2018

Coverage Status

Coverage remained the same at 55.646% when pulling d60069a on gaocegege:fix into 77375ba on kubeflow:master.

Copy link
Member

@ScorpioCPH ScorpioCPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScorpioCPH
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScorpioCPH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6a5ee89 into kubeflow:master May 23, 2018
@gaocegege gaocegege deleted the fix branch May 24, 2018 08:00
yph152 pushed a commit to yph152/tf-operator that referenced this pull request Jun 18, 2018
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants