controller: Remove dup code and use k8s.io/kubernetes/controller #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could just review 4804a2a |
This comment has been minimized.
This comment has been minimized.
|
I forgot to update the test 😟 Will do it later (After 5.15) |
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
Travis tests have failedHey @gaocegege, 2nd Buildgometalinter --config=linter_config.json --vendor ./...3rd Buildgometalinter --config=linter_config.json --vendor ./... |
Signed-off-by: Ce Gao <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Ce Gao <[email protected]>
|
/assign @ScorpioCPH PTAL |
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yph152
pushed a commit
to yph152/tf-operator
that referenced
this pull request
Jun 18, 2018
…eflow#594) * dep: Update Signed-off-by: Ce Gao <[email protected]> * vendor: Update Signed-off-by: Ce Gao <[email protected]> * *: Use k8s.io/kubernetes/controller Signed-off-by: Ce Gao <[email protected]> * test: Fix Signed-off-by: Ce Gao <[email protected]> * test: Fix Signed-off-by: Ce Gao <[email protected]> * test: Fix Signed-off-by: Ce Gao <[email protected]>
jetmuffin
pushed a commit
to jetmuffin/tf-operator
that referenced
this pull request
Jul 9, 2018
…eflow#594) * dep: Update Signed-off-by: Ce Gao <[email protected]> * vendor: Update Signed-off-by: Ce Gao <[email protected]> * *: Use k8s.io/kubernetes/controller Signed-off-by: Ce Gao <[email protected]> * test: Fix Signed-off-by: Ce Gao <[email protected]> * test: Fix Signed-off-by: Ce Gao <[email protected]> * test: Fix Signed-off-by: Ce Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #591
/assign @ScorpioCPH
This change is