*: Remove type ContainerName #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @jlewi @ScorpioCPH |
|
/lgtm |
|
@gaocegege I think you need to resolve the conflicts and then it will automerge. |
Signed-off-by: Ce Gao <[email protected]>
Signed-off-by: Ce Gao <[email protected]>
|
/retest |
Signed-off-by: Ce Gao <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi, ScorpioCPH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ScorpioCPH Could you approve the PR in GitHub review page and merge it manually? I think bot does not work now. |
ScorpioCPH
approved these changes
Mar 6, 2018
jimexist
pushed a commit
to jimexist/tf-operator
that referenced
this pull request
Mar 7, 2018
* *: Remove type ContainerName Signed-off-by: Ce Gao <[email protected]> * replicas_test: Fix the error Signed-off-by: Ce Gao <[email protected]> * rebase: Fix Signed-off-by: Ce Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type for the default name of the container is not needed, and the PR is to eliminate it.
/assign @jlewi @ScorpioCPH
Signed-off-by: Ce Gao [email protected]
This change is