-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove existing presubmit and postsubmit on optional-test-infra #1003
Conversation
This is the PR for deprecating existing kubeflow repository's presubmit depending on optional-test-infra.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
/lgtm Hold until 05/26 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aws-kf-ci-bot, PatrickXYS The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey @PatrickXYS I'm one of the team members of Kubeflow on AWS Can you please help me scope out with the details on what needs to be done to keep the existing infra ? |
So I posted #993 two months ago, and I don't think we've made more progress than two months ago, again on that issue I mentioned, it's not just about credits, it's about account privacy, knowledge transfer, maintenance efforts, etc. I'm afraid there are not many things we can do now, one question I can answer is: you can't and you shouldn't move this one to internal accounts due to AWS's open source policy and privacy. |
Which issue is resolved by this Pull Request:
Resolves #993
Description of your changes:
Remove existing presubmit and postsubmit on optional-test-infra.
Checklist:
If PR related to Optional-Test-Infra,
aws/GitOps
folder:cd aws
make optional-generate
make optional-test
The plan is to submit this PR by 05/26 (Thursday), by then, existing Kubeflow repos still using optional-test-infra as their presubmit test solution will see testing failure.
Thus, merge existing PRs will resolve the issue: