feat(frontend): Add an 'Always use latest version option' for recurring runs. Fixes #11581 #11628
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @muzzlol. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ns. Fixes kubeflow#11581 Signed-off-by: muzzlol <[email protected]>
muzzlol
force-pushed
the
feat-latest-version-checkbox
branch
from
d74d043 to
c09bc4e
Compare
HumairAK
requested review from
mprahl
and removed request for
HumairAK and
zijianjoy
| @@ -204,6 +205,26 @@ function NewRunV2(props: NewRunV2Props) { | |||
| ? !cloneOrigin.recurringRun.no_catchup | |||
| : true; | |||
| const [needCatchup, setNeedCatchup] = useState(initialCatchup); | |||
| const [useLatestVersion, setUseLatestVersion] = useState(() => { | |||
| const saved = localStorage.getItem('useLatestPipelineVersion'); | |||
There was a problem hiding this comment.
My preference is that this preference isn't saved because the user decision is for a particular recurring run they are creating for a particular pipeline, but this preference is a global setting.
It's also not clear that checking this box is causing it to be the default preference in the future.
| @@ -505,6 +525,7 @@ function NewRunV2(props: NewRunV2Props) { | |||
| {...props} | |||
| pipeline={existingPipeline} | |||
| pipelineVersionName={pipelineVersionName} | |||
| disabled={useLatestVersion} | |||
There was a problem hiding this comment.
When it's disabled, the form input still shows "Pipeline Version *" which makes it seem like it's still required but I can't select anything. Could you change the text to something like "Using latest pipeline version" or remove that text?
|
Thanks for the contribution @muzzlol ! This is looking good. Could you also please add tests? |
Description of your changes:
This change introduces a checkbox in the New Run V2 page that allows users to create recurring runs that always use the latest version of a pipeline, without needing to specify a pipeline version ID.
The changes include:
useLatestVersionstate variable to track the checkbox's state.useLatestVersionpreference inlocalStorage.pipeline_version_referencein the API payload to only send thepipeline_idwhenuseLatestVersionis enabled.useLatestVersionis enabled.Checklist: