Implement metrics custom filters #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
johnugeorge
reviewed
Dec 4, 2019
| - namespace | ||
| ## spec | ||
| - (TODO) | ||
| - [spec.metricsCollectorSpec.source.filter.metricsFormat](https://github.com/kubeflow/katib/blob/master/pkg/apis/controller/common/v1alpha3/common_types.go#L94-L98): Its type is string array and each element is regular expression (here it is required that the regular expression must have two top subexpressions, the first matched one will be taken as metric name and the second one as metric value). For now, when metrics collector kind is `File` and `StdOut`, this field can take effect and a default one `([\w|-]+)\s*=\s*((-?\d+)(\.\d+)?)` will be applied if not specified. [Here](https://github.com/kubeflow/katib/blob/master/examples/v1alpha3/file-metricscollector-example.yaml) is an example of customized metrics filter. |
There was a problem hiding this comment.
Can you add few examples of the default regex for the first time users ?
|
Since many PRs are blocked on this, We can merge this PR now. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #939
Special notes for your reviewer:
Release note:
This change is