godep: Remove useless dep #521
Conversation
|
/cc @johnugeorge |
|
PTAL @hougangliu |
|
Do you have to merge this? I have to rebase my PR again :) |
Signed-off-by: Ce Gao <[email protected]>
|
@johnugeorge Oh Since you have changed it, I removed the changes about the gopkg.lock. PTAL |
|
It didn't run tests as prow config was outdated. In general, i think that listing out directories is error prone in Katib as version changes spread across the repo |
|
/lgtm |
|
Yeah, now we cannot find a better way to solve the problem. If we trigger v1alpha1 and v1alpha2 workflow for all PRs, it is easier to get CI errors. Let's keep it and see if there is a better solution. |
Signed-off-by: Ce Gao <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ce Gao [email protected]
What this PR does / why we need it:
I imported a never used dep in lock, this PR is to remove it. Sorry about it.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note:
This change is