Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show studyjob condition when run kubectl get #389

Merged
merged 1 commit into from
Feb 19, 2019
Merged

show studyjob condition when run kubectl get #389

merged 1 commit into from
Feb 19, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Feb 18, 2019

# kubectl get studyjob
NAME                     CONDITION   AGE
random-example-default   Completed   13m
test-grid                Running     3s

This change is Reviewable

@johnugeorge
Copy link
Member

Can you please check if there are any issues when we use additionalPrinterColumns with k8s server version <1.11?

@hougangliu
Copy link
Member Author

it works well (just ignoring additionalPrinterColumns field) for k8s server version < 1.11

@johnugeorge
Copy link
Member

Thanks
/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c0f2f07 into kubeflow:master Feb 19, 2019
@hougangliu hougangliu deleted the show-condition branch April 24, 2019 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants