-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
studyJob with non-kubeflow namespace cannot work #302
Conversation
Before create a non-kubeflow (saying
|
/assign @YujiOshima @richardsliu |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardsliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -1,5 +1,5 @@ | |||
package pkg | |||
|
|||
const ( | |||
ManagerAddr = "vizier-core:6789" | |||
ManagerAddr = "vizier-core.kubeflow:6789" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change added ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kube-dns will assign k8s services a DNS A record for a name of the form my-svc.my-namespace.svc.cluster.local and my-svc.my-namespace. This resolves to the cluster IP of the Service.
vizier-core is service name, and if we don't add namespace, when Pod in non-kubeflow namespace cannot resolve vizier-core to its cluster IP (it tries to resolve vizier-core.non-kubeflow).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I mean to say that vizier core can run in any namespace
Fixes: #301
This change is