Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

studyJob with non-kubeflow namespace cannot work #302

Merged
merged 1 commit into from
Dec 19, 2018
Merged

studyJob with non-kubeflow namespace cannot work #302

merged 1 commit into from
Dec 19, 2018

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Dec 19, 2018

Fixes: #301


This change is Reviewable

@hougangliu
Copy link
Member Author

Before create a non-kubeflow (saying nonkubeflow) namespace studyJob, we should doc that user must run below command:

$ cat mcrbac.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: metrics-collector
  namespace: nonkubeflow
---
kind: ClusterRoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: metrics-collector
  namespace: nonkubeflow
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: metrics-collector
subjects:
- kind: ServiceAccount
  name: metrics-collector
  namespace: nonkubeflow
$ kubeflow apply -f  mcrbac.yaml

@hougangliu
Copy link
Member Author

/assign @YujiOshima @richardsliu

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -1,5 +1,5 @@
package pkg

const (
ManagerAddr = "vizier-core:6789"
ManagerAddr = "vizier-core.kubeflow:6789"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change added ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kube-dns will assign k8s services a DNS A record for a name of the form my-svc.my-namespace.svc.cluster.local and my-svc.my-namespace. This resolves to the cluster IP of the Service.
vizier-core is service name, and if we don't add namespace, when Pod in non-kubeflow namespace cannot resolve vizier-core to its cluster IP (it tries to resolve vizier-core.non-kubeflow).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I mean to say that vizier core can run in any namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants