-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort experiments by descending creation date by default in katib-ui #2498
Sort experiments by descending creation date by default in katib-ui #2498
Conversation
Signed-off-by: Xinmin Du <[email protected]>
It seems that an existing CI test checks if the experiment names are rendered in a alphabetical order: katib/pkg/ui/v1beta1/frontend/cypress/e2e/index-page.cy.ts Lines 30 to 42 in 93bee4d
which conflicts with this pr. I'm wondering if we need to change the test. |
@Doris-xm Yeah, I think we need to change the test. |
…t check order Signed-off-by: Xinmin Du <[email protected]>
5fef940
to
da3fe60
Compare
…der of startTime Signed-off-by: Xinmin Du <[email protected]>
/rerun-all |
1 similar comment
/rerun-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for updating this @Doris-xm. I'll leave it for other maintainers.
/lgtm
/assign @kubeflow/wg-automl-leads @helenxie-bit
Thanks for the contribution! /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution @Doris-xm!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, Electronic-Waste The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ubeflow#2498) * Sort experiments by descending creation date by default in katib-ui Signed-off-by: Xinmin Du <[email protected]> * fix: Update "renders every Experiment name into the table" test to not check order Signed-off-by: Xinmin Du <[email protected]> * fix: Update "renders every Experiment name into the table" test in order of startTime Signed-off-by: Xinmin Du <[email protected]> --------- Signed-off-by: Xinmin Du <[email protected]> Signed-off-by: Gary Miguel <[email protected]>
What this PR does / why we need it:

Showing experiments from newest to oldest by default instead of sorting them by name.
Now the experiments are initially shown as follows:
Which issue(s) this PR fixes :
Fixes #2475
Checklist: