Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort experiments by descending creation date by default in katib-ui #2498

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

Doris-xm
Copy link
Contributor

What this PR does / why we need it:
Showing experiments from newest to oldest by default instead of sorting them by name.
Now the experiments are initially shown as follows:
2025-01-21 17 02 21

Which issue(s) this PR fixes :
Fixes #2475

Checklist:

  • Docs included if any changes are user facing

@Doris-xm
Copy link
Contributor Author

Doris-xm commented Jan 21, 2025

It seems that an existing CI test checks if the experiment names are rendered in a alphabetical order:

it('renders every Experiment name into the table', function () {
cy.visit('/');
cy.wait(['@mockNamespacesRequest', '@mockExperimentsRequest']);
let i = 0;
const experiments = this.experimentsRequest;
// Table is sorted by Name in ascending order by default
// and experiment objects are also sorted alphabetically by name
cy.get(`[data-cy-resource-table-row="Name"]`).each(element => {
expect(element).to.contain(experiments[i].name);
i++;
});
});

which conflicts with this pr. I'm wondering if we need to change the test.

@Electronic-Waste
Copy link
Member

@Doris-xm Yeah, I think we need to change the test.

@Doris-xm Doris-xm force-pushed the sort-experiment-by-time branch from 5fef940 to da3fe60 Compare January 21, 2025 12:03
@Doris-xm
Copy link
Contributor Author

/rerun-all

1 similar comment
@Doris-xm
Copy link
Contributor Author

/rerun-all

Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating this @Doris-xm. I'll leave it for other maintainers.

/lgtm
/assign @kubeflow/wg-automl-leads @helenxie-bit

@helenxie-bit
Copy link
Contributor

Thanks for the contribution!

/lgtm
/assign @kubeflow/wg-automl-leads @kimwnasptd

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @Doris-xm!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, Electronic-Waste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0133983 into kubeflow:master Jan 27, 2025
14 checks passed
garymm pushed a commit to garymm/katib that referenced this pull request Feb 12, 2025
…ubeflow#2498)

* Sort experiments by descending creation date by default in katib-ui

Signed-off-by: Xinmin Du <[email protected]>

* fix: Update "renders every Experiment name into the table" test to not check order

Signed-off-by: Xinmin Du <[email protected]>

* fix: Update "renders every Experiment name into the table" test in order of startTime

Signed-off-by: Xinmin Du <[email protected]>

---------

Signed-off-by: Xinmin Du <[email protected]>
Signed-off-by: Gary Miguel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort experiments by descending creation date by default
4 participants