-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade grpcio version to v1.64.1 #2483
Upgrade grpcio version to v1.64.1 #2483
Conversation
Signed-off-by: Electronic-Waste <[email protected]>
/rerun-all |
2 similar comments
/rerun-all |
/rerun-all |
@tenzen-y @andreyvelich The CI has succeeded. PTAL if you have time👀. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Electronic-Waste <[email protected]> Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]> Signed-off-by: Gary Miguel <[email protected]>
What this PR does / why we need it:
After #2344 got merged, our python grpc client is generated by
buf.build/grpc/python:v1.64.1
. However, our Python SDK still usesgrpcio>=1.41.1
, resulting in some errors like #2427.This is due to the update of grpcio packge (the corresponding PR is grpc/grpc#36371). In v1.64.0, grpcio introduced a parameter
__register_method
tounary_unary
, which would be called by grpc client in:katib/pkg/apis/manager/v1beta1/python/api_pb2_grpc.py
Lines 19 to 23 in eb8af4d
And in
tensorflow/tensorflow:2.13.0
, thegrpcio
version isv1.56.0
while intensorflow/tensorflow:2.17.0
the version isv1.64.1
. So the error occurred intensorflow/tensorflow:2.13.0
, but not intensorflow/tensorflow:2.17.0
.Given the fact that
grpcio
version is outdated, I upgrade thegrpcio
version tov1.64.1
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2427
Checklist:
/cc @kubeflow/wg-automl-leads @helenxie-bit @tariq-hasan