-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] move llm hyperparameter optimisation design image to the proposal directory and rename it #2472
[DOCS] move llm hyperparameter optimisation design image to the proposal directory and rename it #2472
Conversation
- remove redundant folder Signed-off-by: mahdikhashan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM! Thanks for your contribution @mahdikhashan
docs/proposals/2339-hpo-for-llm-fine-tuning/hp-optimization-api-design.jpg
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR! Welcome to Kubeflow community🎉
/lgtm
/assign @kubeflow/wg-automl-leads @tariq-hasan @helenxie-bit
Thanks for the contribution! /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @mahdikhashan 🎉
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, Electronic-Waste The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…sal directory and rename it (kubeflow#2472) - remove redundant folder Signed-off-by: mahdikhashan <[email protected]>
…sal directory and rename it (kubeflow#2472) - remove redundant folder Signed-off-by: mahdikhashan <[email protected]> Signed-off-by: Gary Miguel <[email protected]>
What this PR does / why we need it:
it will improve a document
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2471
Checklist: