Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] move llm hyperparameter optimisation design image to the proposal directory and rename it #2472

Conversation

mahdikhashan
Copy link
Member

What this PR does / why we need it:
it will improve a document

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2471

Checklist:

  • Docs included if any changes are user facing

- remove redundant folder

Signed-off-by: mahdikhashan <[email protected]>
Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM! Thanks for your contribution @mahdikhashan

Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR! Welcome to Kubeflow community🎉

/lgtm
/assign @kubeflow/wg-automl-leads @tariq-hasan @helenxie-bit

@helenxie-bit
Copy link
Contributor

Thanks for the contribution!

/lgtm

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @mahdikhashan 🎉
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, Electronic-Waste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 9531372 into kubeflow:master Jan 8, 2025
2 checks passed
mahdikhashan added a commit to mahdikhashan/katib that referenced this pull request Jan 27, 2025
…sal directory and rename it (kubeflow#2472)

- remove redundant folder

Signed-off-by: mahdikhashan <[email protected]>
garymm pushed a commit to garymm/katib that referenced this pull request Feb 12, 2025
…sal directory and rename it (kubeflow#2472)

- remove redundant folder

Signed-off-by: mahdikhashan <[email protected]>
Signed-off-by: Gary Miguel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] design image in HP Optimization Proposal is in wrong path
4 participants