Remove code generation from release script #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Velichkevich <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
andreyvelich
added a commit
to andreyvelich/katib
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Andrey Velichkevich <[email protected]>
google-oss-prow bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
Signed-off-by: Andrey Velichkevich <[email protected]>
shashank-iitbhu
pushed a commit
to shashank-iitbhu/katib
that referenced
this pull request
Jun 30, 2024
Signed-off-by: Andrey Velichkevich <[email protected]>
shashank-iitbhu
pushed a commit
to shashank-iitbhu/katib
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Andrey Velichkevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the code generation from our release script.
Currently, we have to clone Katib repo to the
$GOPATH/src/github.com/kubeflow/katibto correctly run Go code generation. However, in the release script we clone the Katib repo to the temp directory to avoid un-sync Git history.We don't need to run
make generatein our release script, since we have the code generation check for each PR.Also, we don't need to publish images with COMMIT tag during the release.
/assign @tenzen-y @johnugeorge