Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement validations for darts suggestion service #1926

Merged
merged 9 commits into from
Aug 18, 2022
Merged

Implement validations for darts suggestion service #1926

merged 9 commits into from
Aug 18, 2022
+398 −70

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Aug 14, 2022 •
edited
Loading

What this PR does / why we need it:
I implemented validations for the darts suggestion service.
Also, I commonalized a function to validate NAS operations as pkg/suggestion/v1beta1/nas/common/validate.py.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part-of #1126

Checklist:

  • Docs included if any changes are user facing

@tenzen-y tenzen-y force-pushed the implement-darts-validation-algorithm branch from 5ab03be to 44dead9 Compare August 14, 2022 18:53
@coveralls
Copy link

coveralls commented Aug 14, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 72.857% when pulling d338dd2 on tenzen-y:implement-darts-validation-algorithm into 478e01d on kubeflow:master.

anencore94
anencore94 reviewed Aug 16, 2022
View reviewed changes
tenzen-y and others added 2 commits August 18, 2022 01:06
@tenzen-y
Copy link
Member Author

@anencore94
Could you sign CLA with [email protected]?

https://github.com/kubeflow/katib/pull/1926/checks?check_run_id=7882927727

@tenzen-y tenzen-y force-pushed the implement-darts-validation-algorithm branch from fc010cd to 5d083e0 Compare August 17, 2022 22:16
@anencore94
Copy link
Member

anencore94 commented Aug 18, 2022 •
edited
Loading

@anencore94 Could you sign CLA with [email protected]?

https://github.com/kubeflow/katib/pull/1926/checks?check_run_id=7882927727

Thaks, I was signed in with different email, but now I signed with both email :)

@anencore94
Copy link
Member

Looks good !
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 18, 2022
@tenzen-y
Copy link
Member Author

tenzen-y commented Aug 18, 2022 •
edited
Loading

/hold until corrections are complete.

@google-oss-prow google-oss-prow bot removed the lgtm label Aug 18, 2022
@tenzen-y
Copy link
Member Author

Please take another look since I addressed all your review comments. @anencore94

/hold cancel

@tenzen-y tenzen-y force-pushed the implement-darts-validation-algorithm branch from 5bc97d0 to d338dd2 Compare August 18, 2022 02:23
@tenzen-y tenzen-y requested review from anencore94 and removed request for sperlingxx August 18, 2022 02:33
anencore94
anencore94 approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@anencore94 anencore94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for updates @tenzen-y

@google-oss-prow google-oss-prow bot added the lgtm label Aug 18, 2022
@johnugeorge
Copy link
Member

Thanks @tenzen-y

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anencore94, johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit cae12e6 into kubeflow:master Aug 18, 2022
@tenzen-y tenzen-y deleted the implement-darts-validation-algorithm branch August 18, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anencore94 anencore94 anencore94 approved these changes

Assignees

@anencore94 anencore94

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tenzen-y @coveralls @anencore94 @johnugeorge