Upgrade the kubebuilder to v3.2.0 and Kubernetes Go libraries to v1.22.2 #1861
Conversation
tenzen-y
force-pushed
the
upgrade-kubebuiler-version
branch
4 times, most recently
from
4c6badb to
7b44a36
Compare
tenzen-y
force-pushed
the
upgrade-kubebuiler-version
branch
from
7b44a36 to
46b6ad3
Compare
tenzen-y
force-pushed
the
upgrade-kubebuiler-version
branch
from
76fd8b3 to
a61185e
Compare
tenzen-y
changed the title
|
This PR is ready for review, but we can not run
|
|
/retest |
To avoid the `timeout waiting for process kube-apiserver to stop` error, we must use the `context.WithCancel`. Ref: kubernetes-sigs/controller-runtime#1571 (comment)
tenzen-y
force-pushed
the
upgrade-kubebuiler-version
branch
2 times, most recently
from
e6c3e12 to
84725ee
Compare
tenzen-y
changed the title
tenzen-y
force-pushed
the
upgrade-kubebuiler-version
branch
2 times, most recently
from
60fecbb to
fe95b18
Compare
To avoid the `../../../../pkg/mod/k8s.io/[email protected]/plugin/pkg/client/auth/exec/metrics.go:21:2: package io/fs is not in GOROOT (/usr/local/go/src/io/fs)` error, we must use Go v1.16 or later, but as described in kubeflow/trainer#1581, we do not have permission to update `public.ecr.aws/j1r0q0g6/kubeflow-testing:latest` so we need to update it in this.
tenzen-y
force-pushed
the
upgrade-kubebuiler-version
branch
from
fe95b18 to
faeb84f
Compare
tenzen-y
changed the title
tenzen-y
changed the title
tenzen-y
changed the title
tenzen-y
changed the title
| @@ -76,6 +76,13 @@ if [ $? -ne 1 ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| # TODO (tenzen-y): Once the changes on https://github.com/kubeflow/testing/pull/974 are reflected in the `public.ecr.aws` registry, we must remove this process. | |||
| # To avoid the `../../../../pkg/mod/k8s.io/[email protected]/plugin/pkg/client/auth/exec/metrics.go:21:2: package io/fs is not in GOROOT (/usr/local/go/src/io/fs)` error, | |||
There was a problem hiding this comment.
Is this still needed after kubeflow/testing#974?
There was a problem hiding this comment.
@johnugeorge Thanks for your comments.
Yes, as Jeffwan says, since public.ecr.aws/j1r0q0g6/kubeflow-testing:latest image was manually updated, we can not update its image by merging kubeflow/testing#974.
However, I forget the image public.ecr.aws/j1r0q0g6/kubeflow-testing:latest was manually updated in the past.
There was a problem hiding this comment.
Ref: https://gallery.ecr.aws/j1r0q0g6/kubeflow-testing (Amazon ECR Public)
| @@ -76,6 +76,13 @@ if [ $? -ne 1 ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| # TODO (tenzen-y): Once the changes on https://github.com/kubeflow/testing/pull/974 are reflected in the `public.ecr.aws` registry, we must remove this process. | |||
| # To avoid the `../../../../pkg/mod/k8s.io/[email protected]/plugin/pkg/client/auth/exec/metrics.go:21:2: package io/fs is not in GOROOT (/usr/local/go/src/io/fs)` error, | |||
There was a problem hiding this comment.
Also, wondering why this error is happening only for Golang version <1.6?
|
Thanks for clarifying. Can you create an issue to ensure that we remove the hack after the image update ? |
Sure. |
|
Thanks @tenzen-y for this fix! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I upgraded the kubebuilder to v3.2.0, the Kubernetes Go libraries to v1.22.2, and other dependent libraries.
Also, I fixed envtest for the experiment controller.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1858
Checklist: