Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shellcheck #1857

Merged
merged 17 commits into from
May 3, 2022
Merged

Add shellcheck #1857

merged 17 commits into from
May 3, 2022

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented May 1, 2022 •
edited
Loading

What this PR does / why we need it:

I added shellcheck to verify all shell scripts in this repository.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #1734

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow google-oss-prow bot requested review from anencore94 and sperlingxx May 1, 2022 04:52
@coveralls
Copy link

coveralls commented May 1, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 73.762% when pulling 1ea6c33 on tenzen-y:issue-1734-add-shellcheck into e9e8eab on kubeflow:master.

@tenzen-y tenzen-y force-pushed the issue-1734-add-shellcheck branch from 21e5b20 to dccbcf8 Compare May 1, 2022 05:01
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels May 1, 2022
@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels May 1, 2022
@tenzen-y tenzen-y force-pushed the issue-1734-add-shellcheck branch from 40fddea to 4379399 Compare May 1, 2022 12:34
@tenzen-y tenzen-y force-pushed the issue-1734-add-shellcheck branch from a5a560a to 1cc45fe Compare May 1, 2022 13:45
@tenzen-y tenzen-y changed the title [WIP] Add shellcheck Add shellcheck May 1, 2022
@tenzen-y tenzen-y force-pushed the issue-1734-add-shellcheck branch 2 times, most recently from 2688a57 to deea56f Compare May 1, 2022 15:59
@tenzen-y tenzen-y force-pushed the issue-1734-add-shellcheck branch from deea56f to 1ea6c33 Compare May 1, 2022 15:59
@tenzen-y
Copy link
Member Author

tenzen-y commented May 1, 2022

/retest

@tenzen-y tenzen-y mentioned this pull request May 2, 2022
Closed
gaocegege
gaocegege approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 👍 Great improvement for katib

/lgtm

/cc @kubeflow/wg-automl-leads

@google-oss-prow google-oss-prow bot requested a review from a team May 3, 2022 01:13
@google-oss-prow google-oss-prow bot added the lgtm label May 3, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3993404 into kubeflow:master May 3, 2022
@tenzen-y tenzen-y deleted the issue-1734-add-shellcheck branch May 3, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege approved these changes

@anencore94 anencore94 Awaiting requested review from anencore94

@sperlingxx sperlingxx Awaiting requested review from sperlingxx

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tenzen-y @coveralls @gaocegege