-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Multivariate TPE to Katib UI #1625
Add Multivariate TPE to Katib UI #1625
Conversation
@andreyvelich: GitHub didn't allow me to assign the following users: g-votte. Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please show the preview of it?
@@ -78,6 +78,8 @@ export const TPESettings: AlgorithmSetting[] = [ | |||
}, | |||
]; | |||
|
|||
export const MultivariateTPESettings: AlgorithmSetting[] = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multivariate TPE accepts the following algorithm settings:
startup_trials
: integerei_candidates
: integerrandom_state
: integer
katib/pkg/suggestion/v1beta1/optuna/service.py
Lines 72 to 77 in 7439a37
if k == "startup_trials": | |
kwargs["n_startup_trials"] = int(v) | |
elif k == "ei_candidates": | |
kwargs["n_ei_candidates"] = int(v) | |
elif k == "random_state": | |
kwargs["seed"] = int(v) |
This is one extra algorithm add in the UI |
Got merged accidentally since it was already approved. Can we address the comments in separate PR? |
Agree 👍 I think it doesn't need to revert the commit. |
I updated Katib UI with Multivariate TPE Algorithm.
Also, I modified some Experiment parameters in create page.
/assign @c-bata @g-votte @kimwnasptd