Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Close menu on click #1114

Merged
merged 2 commits into from
Apr 1, 2020
Merged

UI: Close menu on click #1114

merged 2 commits into from
Apr 1, 2020

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Mar 28, 2020 •
edited
Loading

This PR:

  1. Fixes: Clicking on a panel item doesn't close the panel #636. Close menu after click.
  2. I deleted "About" page, since it is not needed.
  3. Information Snack Bar closes after 6 seconds. It is not necessary to click on close icon.
  4. I added Material UI link to the Katib UI README and link from developer-guide.

MenU Click

/assign @johnugeorge @gaocegege
/cc @richardsliu

@andreyvelich
Close menu on click
f754c94 
Fix close time for snackbar
Add Material UI to the README
Add link to developer guide
@andreyvelich
Change README
7c2d7a3
@kubeflow-bot
Copy link

This change is Reviewable

@andreyvelich
Copy link
Member Author

/retest

2 similar comments
@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

/retest

gaocegege
gaocegege reviewed Mar 30, 2020
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @johnugeorge

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

/retest

4 similar comments
@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit bccc281 into kubeflow:master Apr 1, 2020
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
@andreyvelich
UI: Close menu on click (kubeflow#1114)
a916410 
* Close menu on click
Fix close time for snackbar
Add Material UI to the README
Add link to developer guide

* Change README
@andreyvelich andreyvelich deleted the ui-click-close-menu branch October 6, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@richardsliu richardsliu Awaiting requested review from richardsliu

Assignees

@johnugeorge johnugeorge

@gaocegege gaocegege

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking on a panel item doesn't close the panel
5 participants
@andreyvelich @kubeflow-bot @johnugeorge @k8s-ci-robot @gaocegege